Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/temp diff #27

Merged
merged 13 commits into from
Aug 8, 2023
Merged

Bug/temp diff #27

merged 13 commits into from
Aug 8, 2023

Conversation

seanpearsonuk
Copy link
Collaborator

@seanpearsonuk seanpearsonuk commented Aug 8, 2023 •
edited
Loading

Addressing bugs in #25

BUG
Garbage input is allowed

>>> v.to("piggy")
Quantity (60.0, "piggy")
>>> v = Quantity(60.0, "chicken")

General fixes around (see tests, new and old (updated)):

  • Incorrect handling of division
  • Incorrect handling of temperature, temperature difference

@seanpearsonuk seanpearsonuk merged commit 2bcb2bc into main Aug 8, 2023
4 checks passed
@acarvalh-work acarvalh-work deleted the bug/temp_diff branch August 15, 2023 14:10
@dnwillia-work dnwillia-work linked an issue Aug 17, 2023 that may be closed by this pull request
Garbage input is allowed. #24
Closed
@hpohekar hpohekar mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prmukherj prmukherj prmukherj approved these changes

@hpohekar hpohekar hpohekar approved these changes

@mkundu1 mkundu1 mkundu1 approved these changes

@acarvalh-work acarvalh-work Awaiting requested review from acarvalh-work

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Garbage input is allowed.
4 participants
@seanpearsonuk @mkundu1 @hpohekar @prmukherj