CHORE: Second pass of oss code review #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this workflow is working
|
@philipjusher Following our conversation, here are some changes. |
SMoraisAnsys
added
documentation
github-actions
bot
added
testing
|
@philipjusher You should probably take into account @PipKat review (#39) before looking at this PR. |
…yconceptev-core into chore/oss-review-code-1
SMoraisAnsys
commented
May 27, 2024
SMoraisAnsys
commented
May 27, 2024
SMoraisAnsys
changed the title
SMoraisAnsys
changed the title
philipjusher
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #36, partially addresses #35.
The github configuration needs to be updated and release / doc should be tested.