Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposition of the mesh_info_provider in Python and output as derived class #1007

Merged
merged 116 commits into from
Jul 12, 2023

Conversation

MichaelNale
Copy link
Contributor

No description provided.

@MichaelNale MichaelNale marked this pull request as ready for review July 11, 2023 13:27
@MichaelNale MichaelNale reopened this Jul 12, 2023
self._server = server_module.get_or_create_server(server)

if generic_data_container is None and mesh_info is None:
self._generic_data_container = GenericDataContainer()
Copy link
Contributor

@PProfizi PProfizi Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self._generic_data_container = GenericDataContainer()
self._generic_data_container = GenericDataContainer(server=self._server)

@MichaelNale

@rafacanton rafacanton self-requested a review July 12, 2023 12:01
@rafacanton rafacanton dismissed their stale review July 12, 2023 12:03

Finally not reviewed

@MichaelNale MichaelNale merged commit bc651fa into master Jul 12, 2023
@MichaelNale MichaelNale deleted the mnale/mesh_info branch July 12, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants