add data-tree list-attributes #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1025 +/- ##
==========================================
- Coverage 88.55% 88.44% -0.12%
==========================================
Files 78 78
Lines 8869 8887 +18
==========================================
+ Hits 7854 7860 +6
- Misses 1015 1027 +12 |
cbellot000
reviewed
Jul 13, 2023
src/ansys/dpf/core/data_tree.py
Outdated
| @@ -482,6 +482,16 @@ def get_as(self, name, type_to_return=types.string): | |||
| out = DataTree(data_tree=obj, server=self._server) | |||
| return out | |||
|
|
|||
| def get_attributes(self): | |||
There was a problem hiding this comment.
@jose-henriquezroa could you please add a dosctring and in this docstring precise whether sub attributes are returned or not (whether this function is recursive basically?))
To comply with our other python classes I would make this function a property instead, what do you think?
cbellot000
approved these changes
Jul 19, 2023
|
|
||
| def to_dict(self): | ||
| """ | ||
| Returns a dictionary representation of the DataTree |
There was a problem hiding this comment.
I like the idea!
Suggested change
| Returns a dictionary representation of the DataTree | |
| Returns a read only dictionary representation of the DataTree |
|
|
||
| return coll_obj.get_integral_entries() | ||
|
|
||
| def get_sub_tree_names(self): |
There was a problem hiding this comment.
Could we use properties here please to be consistent with other classes, ie: "attribute_name", "sub_stree_names"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed DataTree function for listing attributes.