Fix issues with PyVista 0.41.0 #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PProfizi
added
bug
Codecov Report
@@ Coverage Diff @@
## master #1045 +/- ##
==========================================
- Coverage 88.71% 80.44% -8.28%
==========================================
Files 78 78
Lines 8887 8887
==========================================
- Hits 7884 7149 -735
- Misses 1003 1738 +735 |
…th scalar bars only on the GitHub doc CI
rafacanton
approved these changes
Jul 20, 2023
jose-henriquezroa
approved these changes
Jul 20, 2023
|
This is great. But we will need a patch release for this ;) |
PProfizi
added a commit
that referenced
this pull request
Jul 21, 2023
* Set pyvista==0.41.0 * Use pv.global_theme instead of deprecated pv.rcParams * Use pv.global_theme instead of deprecated pv.rcParams * Set back to PyVista 0.36.1 in requirements_docs.txt, stil an issue with scalar bars only on the GitHub doc CI (cherry picked from commit dd09263)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for PyVista 0.41.0 released this morning.
This apparently removed the deprecated
pv.rcParamswe were still using and is breaking all our pipeline runs.Still having an issue (which I never managed to reproduce locally neither on Windows not on Linux) with doc generation on GitHub though, requiring
pyvista==0.36.1: