Update Operators for DPF 241 on master #1131
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #1131 +/- ##
==========================================
+ Coverage 87.37% 87.39% +0.02%
==========================================
Files 81 81
Lines 9197 9197
==========================================
+ Hits 8036 8038 +2
+ Misses 1161 1159 -2 |
| """Compute the measure of the Elements (volume for 3D elements, surface | ||
| for 2D elements or length for 1D elements) using default shape | ||
| functions, except for polyhedrons. |
There was a problem hiding this comment.
@MichaelNale @rafacanton it does not say what happens in the case of polyhedrons
There was a problem hiding this comment.
It uses geometrical considerations to compute volume in that case, but I agree, it could be mentioned
| If not provided, the measure of all elements | ||
| for the mesh is computed. if | ||
| provided, the scoping needs to have | ||
| "elemental" location. |
There was a problem hiding this comment.
| If not provided, the measure of all elements | |
| for the mesh is computed. if | |
| provided, the scoping needs to have | |
| "elemental" location. | |
| If not provided, the measure is computed | |
| for each element in the mesh. If | |
| provided, the scoping needs to have | |
| "elemental" location. |
| class faces_area(Operator): | ||
| """Compute the measure of the Faces (surface for 2D faces of a 3D model | ||
| or length for 1D faces of a 2D model) using default shape | ||
| functions, except for polygons. |
There was a problem hiding this comment.
@MichaelNale @rafacanton same here, what happens in the case of polygons?
There was a problem hiding this comment.
same as above, it employs pure geometry
| If not provided, the measure of all faces in | ||
| the mesh is computed. if provided, | ||
| the scoping needs to have "faces" | ||
| location. |
There was a problem hiding this comment.
@MichaelNale @rafacanton same here, is it "the measure of all faces in the mesh" or "the measure of each face in the mesh"?
|
@PProfizi I will merge it so the operators are up-to-date and make a note to improve the specs of the faces and elements calculations as per your comments. Thanks! |
An update of operators has been triggered either manually or by an update in the dpf-standalone repository.