Fix bug 843531 - DPF: Access violation when DataSource is incorrectly constructed #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1139 +/- ##
==========================================
- Coverage 87.48% 87.35% -0.14%
==========================================
Files 81 81
Lines 9197 9202 +5
==========================================
- Hits 8046 8038 -8
- Misses 1151 1164 +13 📢 Have feedback on the report? Share it here. |
PProfizi
reviewed
Sep 7, 2023
PProfizi
approved these changes
Sep 8, 2023
PProfizi
reviewed
Sep 8, 2023
| @@ -61,6 +61,9 @@ def test_print_data_sources(allkindofcomplexity, server_type): | |||
|
|
|||
|
|
|||
| def test_data_sources_from_data_sources(allkindofcomplexity, server_type): | |||
| with pytest.raises(ValueError) as e: | |||
| data_sources_false = dpf.core.DataSources(data_sources="Wrong Input", server=server_type) | |||
There was a problem hiding this comment.
@MichaelNale FYI, since I saw Codacy complaining, the pythonic thing to do here instead of having an unused variable is:
Suggested change
| data_sources_false = dpf.core.DataSources(data_sources="Wrong Input", server=server_type) | |
| _ = dpf.core.DataSources(data_sources="Wrong Input", server=server_type) |
MichaelNale
added a commit
that referenced
this pull request
Sep 15, 2023
… constructed (#1146) * Revert "Revert "Fix bug 843531 - DPF: Access violation when DataSource is incorrectly constructed (#1139)" (#1145)" This reverts commit d03c968. * Fix bug 843531 * Update the PR : modify the condition and change the test * Update the PR : keep the condition using DESCRIPTOR attribute for grpc message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.