Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Vale filter to nofilter #1192

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

PProfizi
Copy link
Contributor

Limiting to added is not working when the CI runs on a merge commit on master when the diff is empty on files targeted by Vale.

@PProfizi PProfizi added the CI/CD Related to CI/CD label Oct 10, 2023
@PProfizi PProfizi self-assigned this Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1192 (670cb47) into master (28f64aa) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1192      +/-   ##
==========================================
+ Coverage   87.34%   87.38%   +0.03%     
==========================================
  Files          81       81              
  Lines        9224     9224              
==========================================
+ Hits         8057     8060       +3     
+ Misses       1167     1164       -3     

@PProfizi PProfizi merged commit 83dbd80 into master Oct 10, 2023
27 checks passed
@PProfizi PProfizi deleted the ci/vale_nofilter_for_master branch October 10, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants