Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test_resultinfo.py retrocompatible with DPF 7.0 #1199

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Oct 12, 2023

The update of test_resultinfo.py made following an update in the result file reference did not filter for DPF 7.1 but for DPF 7.0, which is wrong.

Before:
https://github.com/ansys/pydpf-core/actions/runs/6496374240/job/17643178410#logs
After:
https://github.com/ansys/pydpf-core/actions/runs/6496892196

@PProfizi PProfizi added the CI/CD Related to CI/CD label Oct 12, 2023
@PProfizi PProfizi added this to the v0.10.0 milestone Oct 12, 2023
@PProfizi PProfizi self-assigned this Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1199 (56550ad) into master (b21be1b) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1199      +/-   ##
==========================================
- Coverage   87.30%   87.29%   -0.02%     
==========================================
  Files          81       81              
  Lines        9224     9231       +7     
==========================================
+ Hits         8053     8058       +5     
- Misses       1171     1173       +2     

@PProfizi PProfizi merged commit 7ad9470 into master Oct 12, 2023
63 of 80 checks passed
@PProfizi PProfizi deleted the fix/test_retrocompatibility branch October 12, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants