Refactor version handling #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1205 +/- ##
==========================================
- Coverage 87.25% 87.24% -0.01%
==========================================
Files 81 81
Lines 9224 9223 -1
==========================================
- Hits 8048 8047 -1
Misses 1176 1176 |
cbellot000
approved these changes
Oct 13, 2023
| } | ||
|
|
||
| class ServerToAnsysVersion: | ||
| legacy_version_map = { |
There was a problem hiding this comment.
why is that called legacy?
There was a problem hiding this comment.
@cbellot000 the legacy versioning logic, vs the new one following the Ansys product versioning, but I can change the name, no problem
There was a problem hiding this comment.
I think calling it legacy makes it clear it should not be changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a refactor of
ansys.dpf.core._version.py'sserver_to_ansys_versionto enable handlingXXXX.Y.ZDPF versioning while retaining retro-compatibility.It also removes
server_to_ansys_grpc_dpf_versionasansys.grpc.dpfis now shipped withinansys-dpf-core.Instead, what is checked when connecting to a server via gRPC is whether the DPF server we try to connect to has a version at least equal to the
min_server_versionvariable, which is the minimal DPF version supported by the currentansys-dpf-corepackage.