Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove criterion on v tag on branch calling the releaser.yml #1231

Merged

Conversation

PProfizi
Copy link
Contributor

as it can be manually called from another branch

@PProfizi PProfizi added this to the v0.10.0 milestone Oct 19, 2023
@PProfizi PProfizi self-assigned this Oct 19, 2023
@PProfizi PProfizi added the CI/CD Related to CI/CD label Oct 19, 2023
@PProfizi PProfizi changed the title Remove criterion on tag on branch calling the releaser.yml Remove criterion on v tag on branch calling the releaser.yml Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1231 (b1688ae) into master (85e80b0) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head b1688ae differs from pull request most recent head df9e419. Consider uploading reports for the commit df9e419 to get more accurate results

@@            Coverage Diff             @@
##           master    #1231      +/-   ##
==========================================
+ Coverage   87.22%   87.27%   +0.04%     
==========================================
  Files          81       81              
  Lines        9223     9223              
==========================================
+ Hits         8045     8049       +4     
+ Misses       1178     1174       -4     

@PProfizi PProfizi merged commit 0428065 into master Oct 19, 2023
31 of 33 checks passed
@PProfizi PProfizi deleted the ci/release_does_not_require_tag_v_on_branch_calling_it branch October 19, 2023 17:17
PProfizi added a commit that referenced this pull request Oct 19, 2023
* Remove criterion on tag on branch calling the releaser.yml as it can be manually called from another branch

* Fix wheelhouse naming

* Do not look for a tarball to upload to the draft release as these are automatically generated by GH upon creation of the release.

* Do not upload tarball and zip sources to PyPI as they are automatically generated by GH and are broken right now.

(cherry picked from commit 0428065)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant