Don't create LocalField when using InProcess #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1243 +/- ##
==========================================
+ Coverage 87.23% 87.29% +0.05%
==========================================
Files 81 81
Lines 9223 9229 +6
==========================================
+ Hits 8046 8056 +10
+ Misses 1177 1173 -4 |
ansys-akarcher
changed the title
PProfizi
reviewed
Oct 27, 2023
PProfizi
approved these changes
Oct 27, 2023
Co-authored-by: Paul Profizi <100710998+PProfizi@users.noreply.github.com>
cbellot000
reviewed
Oct 27, 2023
| @@ -494,6 +494,12 @@ def _get_data(self, np_array=True): | |||
| def _set_data(self, data): | |||
| pass | |||
|
|
|||
| def __enter__(self): | |||
There was a problem hiding this comment.
@ansys-akarcher is that needed to do with statement?
There was a problem hiding this comment.
@cbellot000
__enter__ and __exit__ are indeed required as now as_local_field() may be returning either a Field Object or a LocalField (which was defining __enter__ and __exit__)
cbellot000
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Local field primary goal is to copy the data when a field is remote, and very costly to access, which is not the case when the DPF server is used InProcess.
For now I didn't find an impactful and minimal way to get faster on get_entity_data_* methods.