Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map int32 operator output to int #1295

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Nov 28, 2023

Users trying to create Operators with int32 defined in their specs need it to be treated as an int for it to be understood by PyDPF-Core.
The user who reported the issue confirmed that this modification fixed the issue.

@PProfizi PProfizi added the enhancement New feature or request label Nov 28, 2023
@PProfizi PProfizi self-assigned this Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #1295 (25246f3) into master (8048e2b) will increase coverage by 1.43%.
Report is 2 commits behind head on master.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1295      +/-   ##
==========================================
+ Coverage   86.18%   87.62%   +1.43%     
==========================================
  Files          81       81              
  Lines        9258     9236      -22     
==========================================
+ Hits         7979     8093     +114     
+ Misses       1279     1143     -136     

@PProfizi PProfizi merged commit 057bd32 into master Nov 28, 2023
35 of 36 checks passed
@PProfizi PProfizi deleted the fix/int32_operator_output branch November 28, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants