improve runtime client config #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1314 +/- ##
==========================================
+ Coverage 87.45% 87.55% +0.10%
==========================================
Files 81 81
Lines 9236 9255 +19
==========================================
+ Hits 8077 8103 +26
+ Misses 1159 1152 -7 |
cbellot000
commented
Dec 8, 2023
PProfizi
reviewed
Dec 8, 2023
src/ansys/dpf/gate/misc.py
Outdated
| @@ -1,11 +1,33 @@ | |||
| DEFAULT_FILE_CHUNK_SIZE = None | |||
| COMMON_PROGRESS_BAR = None | |||
| _CLIENT_CONFIG = {} | |||
|
|
|||
There was a problem hiding this comment.
@cbellot000 do we have an equivalent PR on pygate?
anseramosfe
approved these changes
Dec 11, 2023
rafacanton
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: The runtime client config is only client side: it should not start a server
when a client is created a after client setting are changed: the client should take into account these changes