Improve server branch selection #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erver-sync action.
…erver-sync action.
…erver-sync action.
…erver-sync action.
…erver-sync action.
anseramosfe
approved these changes
Dec 12, 2023
.github/workflows/ci.yml
Outdated
Comment on lines
46
to
52
| if [[ ${{ github.event_name == 'push' }} ]]; then | ||
| echo "suffix=''" >> "$GITHUB_OUTPUT" | ||
| fi | ||
| if [[ ${{ github.event_name == 'workflow_dispatch' }} ]]; then | ||
| echo "suffix=${{ github.event.inputs.standalone_branch_suffix }}" >> "$GITHUB_OUTPUT" | ||
| fi | ||
| if [[ ${{ github.event_name == 'pull_request' }} ]]; then |
There was a problem hiding this comment.
if..elif..else here? As the conditions are mutually exclusive.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1322 +/- ##
=======================================
Coverage 86.24% 86.24%
=======================================
Files 81 81
Lines 9236 9236
=======================================
Hits 7966 7966
Misses 1270 1270 |
…erver-sync action.
…erver-sync action.
…erver-sync action.
…erver-sync action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add standalone_suffix pick job in CI for cases where PR is run by a server-sync action.