Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Collection.name #1335

Merged
merged 10 commits into from
Feb 7, 2024
Merged

Expose Collection.name #1335

merged 10 commits into from
Feb 7, 2024

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Dec 22, 2023

Allows to get and set names for Collections (missing api for LegacyGrpc)
Necessary to allow exporting named custom results to VTU.

TODO:

  • Add gRPC

Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi PProfizi added the enhancement New feature or request label Dec 22, 2023
@PProfizi PProfizi self-assigned this Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85121d4) 87.84% compared to head (f13894d) 87.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1335      +/-   ##
==========================================
+ Coverage   87.84%   87.86%   +0.01%     
==========================================
  Files          81       81              
  Lines        9538     9548      +10     
==========================================
+ Hits         8379     8389      +10     
  Misses       1159     1159              

Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi PProfizi requested a review from cbellot000 December 22, 2023 16:50
@PProfizi PProfizi assigned rafacanton and unassigned rafacanton Dec 22, 2023
@PProfizi PProfizi requested a review from rafacanton December 22, 2023 17:15
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@cbellot000
Copy link
Contributor

@PProfizi is it straightforward to add it in legacy grpc as well? We now have big customers using it, if we could prevent having too many differences between our server config I think it would be good

Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi
Copy link
Contributor Author

PProfizi commented Jan 2, 2024

@PProfizi is it straightforward to add it in legacy grpc as well? We now have big customers using it, if we could prevent having too many differences between our server config I think it would be good

Hey @cbellot000, the goal is to implement it for all types of connections, hence the testing being activated for all 3 types. Now it works for InProcess, my next step will be to implement changes so it is available via gRPC too.

Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi PProfizi requested a review from a team as a code owner January 4, 2024 17:10
@PProfizi PProfizi removed the request for review from a team February 6, 2024 09:11
@PProfizi PProfizi merged commit c16f56b into master Feb 7, 2024
40 checks passed
@PProfizi PProfizi deleted the feat/expose_collection_name branch February 7, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants