-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Collection.name #1335
Expose Collection.name #1335
Conversation
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1335 +/- ##
==========================================
+ Coverage 87.84% 87.86% +0.01%
==========================================
Files 81 81
Lines 9538 9548 +10
==========================================
+ Hits 8379 8389 +10
Misses 1159 1159 |
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi is it straightforward to add it in legacy grpc as well? We now have big customers using it, if we could prevent having too many differences between our server config I think it would be good |
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Hey @cbellot000, the goal is to implement it for all types of connections, hence the testing being activated for all 3 types. Now it works for InProcess, my next step will be to implement changes so it is available via gRPC too. |
Allows to get and set names for Collections (missing api for LegacyGrpc)
Necessary to allow exporting named custom results to VTU.
TODO: