Allow update of dpf-site.zip #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r.py (WIP) Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
cbellot000
reviewed
Jan 25, 2024
| # Otherwise get the path to the site_packages of the current virtual environment | ||
| current_site_packages_path = None | ||
| # Zip it | ||
| # Store original dpf-site.zip for this DPF Server |
There was a problem hiding this comment.
I don't understand what this code is doing, sorry
There was a problem hiding this comment.
@cbellot000, updated to a working version, tested locally
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1379 +/- ##
==========================================
- Coverage 87.54% 87.24% -0.30%
==========================================
Files 81 81
Lines 9360 9401 +41
==========================================
+ Hits 8194 8202 +8
- Misses 1166 1199 +33 |
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
cbellot000
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the current venv.
Store the original
dpf-site.zipand give arestoreoption.