Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_entry.py::test_license_agr #1381

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Conversation

ansys-akarcher
Copy link
Contributor

@ansys-akarcher ansys-akarcher commented Jan 26, 2024

Following license changes in DPF Server, this test was failing

Basically the behavior should not be modified apart from the Operator Construction also throwing a DPF LA Exception.

However the test seemed to run an InProcessServer before even actually running the line which starts a server.

Which caused all plugins to be already loaded, and DPF to be already loaded, and I believe biasing the expected environnement of the test.

This should be merged in synchronization with the Licensing modifications server side

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0b7883) 87.54% compared to head (8576ac3) 86.85%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1381      +/-   ##
==========================================
- Coverage   87.54%   86.85%   -0.69%     
==========================================
  Files          81       81              
  Lines        9360     9646     +286     
==========================================
+ Hits         8194     8378     +184     
- Misses       1166     1268     +102     

tests/entry/test_entry.py Outdated Show resolved Hide resolved
@PProfizi PProfizi added the bug Something isn't working label Jan 26, 2024
tests/entry/test_entry.py Outdated Show resolved Hide resolved
@ansys-akarcher ansys-akarcher merged commit 9b80126 into master Feb 5, 2024
107 of 108 checks passed
@ansys-akarcher ansys-akarcher deleted the fix/test_license_agr branch February 5, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants