Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of ansys_path version in start_local_server #1388

Merged
merged 10 commits into from
Jan 30, 2024

Conversation

PProfizi
Copy link
Contributor

Stop throwing silently when DPF version of ansys_path is not understood, and parse folder name when dpf_standalone

…od, and parse folder name when dpf_standalone

Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi PProfizi added the bug Something isn't working label Jan 30, 2024
@PProfizi PProfizi added this to the v0.11.0 milestone Jan 30, 2024
@PProfizi PProfizi self-assigned this Jan 30, 2024
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ff6d0f3) 86.84% compared to head (368c0ef) 86.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1388   +/-   ##
=======================================
  Coverage   86.84%   86.84%           
=======================================
  Files          81       81           
  Lines        9484     9482    -2     
=======================================
- Hits         8236     8235    -1     
+ Misses       1248     1247    -1     

@PProfizi PProfizi merged commit 6bddcba into master Jan 30, 2024
40 checks passed
@PProfizi PProfizi deleted the fix/ansys_path_version_parse branch January 30, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant