Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GrpcServer deletion after initialization failure #1405

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Fix GrpcServer deletion after initialization failure #1405

merged 1 commit into from
Feb 7, 2024

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Feb 7, 2024

Set self.live=False before starting initialization of a grpc server.

@PProfizi
Set self.live=False before starting initialization of a grpc server
cc7e24a 
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi PProfizi added the bug Something isn't working label Feb 7, 2024
@PProfizi PProfizi self-assigned this Feb 7, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f1c99f) 86.69% compared to head (cc7e24a) 87.84%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1405      +/-   ##
==========================================
+ Coverage   86.69%   87.84%   +1.15%     
==========================================
  Files          81       81              
  Lines        9537     9538       +1     
==========================================
+ Hits         8268     8379     +111     
+ Misses       1269     1159     -110

@PProfizi PProfizi merged commit 1ad563d into master Feb 7, 2024
40 checks passed
@PProfizi PProfizi deleted the fix/grpcserver_deletion_when_init_failed branch February 7, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansys-akarcher ansys-akarcher ansys-akarcher approved these changes

@cbellot000 cbellot000 Awaiting requested review from cbellot000

@rafacanton rafacanton Awaiting requested review from rafacanton

Assignees

@PProfizi PProfizi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PProfizi @ansys-akarcher