-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Getting Started and add Licensing #1423
Conversation
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1423 +/- ##
==========================================
- Coverage 87.85% 87.84% -0.02%
==========================================
Files 81 81
Lines 9543 9543
==========================================
- Hits 8384 8383 -1
- Misses 1159 1160 +1 |
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi As a generic comment, I think that the general licensing doc is a bit convoluted. We have it in 2 places:
Do you think we could merge both in one page? (that way if a user wants to know about licensing they don't need to go back-and-forth between 2 pages) |
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
I agree that information is a bit all over the place. Still, the idea was to have this new page dedicated to licensing, whereas the |
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi Thanks or all the refactoring, I think that the doc is very clear and modularized! (I just added minor comments about versioning strings that we may want to explicitly delete, or to make sure that we will update with each new server release) |
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Thanks @rafacanton, I updated the versions as you remarked. |
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Thanks @JennaPaikowsky! I'll implement the changes in the next PR. |
This PR updates the documentation regarding the DPF licensing for
2024.2.pre0
.Also documents
dyna
as a valid license increment.