Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PropertyField.name #1469

Merged
merged 7 commits into from
Apr 10, 2024
Merged

Add PropertyField.name #1469

merged 7 commits into from
Apr 10, 2024

Conversation

PProfizi
Copy link
Contributor

No description provided.

PProfizi added 2 commits March 13, 2024 16:52
@PProfizi
Add the FieldDefinition to the PropertyField and get/set the name thr…
a87f197 
…ough it.

Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi
Add testing
524053f 
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi PProfizi added the enhancement New feature or request label Mar 13, 2024
@PProfizi PProfizi added this to the v0.11.1 milestone Mar 13, 2024
@PProfizi PProfizi self-assigned this Mar 13, 2024
@PProfizi
Fix retro-compatibility
ebf61ee 
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@wiz-inc-572fc38784
Copy link

wiz-inc-572fc38784 bot commented Mar 14, 2024 •
edited
Loading

Wiz Scan Summary
IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑

@PProfizi
Fix retro-compatibility
4a3fe7a 
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 86.29%. Comparing base (a9d68bb) to head (4a3fe7a).
Report is 5 commits behind head on master.

❗ Current head 4a3fe7a differs from pull request most recent head 5236a50. Consider uploading reports for the commit 5236a50 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1469      +/-   ##
==========================================
- Coverage   86.81%   86.29%   -0.52%     
==========================================
  Files          82       82              
  Lines        9631     9639       +8     
==========================================
- Hits         8361     8318      -43     
- Misses       1270     1321      +51

PProfizi and others added 3 commits April 10, 2024 10:59
@PProfizi
Merge branch 'master' into feat/property_field_name
c6bc790
@PProfizi
Add typehinting
b26d34c 
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi
Add @version_requires decorators to new properties
5236a50 
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi PProfizi merged commit 9a99ff2 into master Apr 10, 2024
37 checks passed
@PProfizi PProfizi deleted the feat/property_field_name branch April 10, 2024 12:17
@PProfizi PProfizi modified the milestones: v0.12.1, v0.12.0 Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafacanton rafacanton rafacanton approved these changes

@cbellot000 cbellot000 Awaiting requested review from cbellot000

Assignees

@PProfizi PProfizi

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@PProfizi @codecov-commenter @rafacanton