Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception to plot MeshesContainers containing empty meshes #1491

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

rafacanton
Copy link
Contributor

@rafacanton rafacanton commented Apr 8, 2024

An exception is introduced in the code that plots MeshesContainers to be able to plot it if any of the MeshedRegions in the container is empty. While working lately with isocontours in distributed, it may be the case that an isocontour does not pass through a given partition of the spatial domain. If that is the case, the isocontour mesh for that partition is an empty mesh (as it should, with 0 nodes and 0 elements). If all the isocontours are stored in a MeshesContainer, you end up with several meshes being empty and some not. As a user, I'd like to do meshes_container.plot() and still have a plot. This PR enables that.

Tested interactively with a MeshesContainer comprised of entirely empty meshes and a white pyvista plotter pops-up (as it should).

@rafacanton rafacanton requested a review from PProfizi April 8, 2024 07:33
@rafacanton rafacanton self-assigned this Apr 8, 2024
@rafacanton rafacanton added the enhancement New feature or request label Apr 8, 2024
@rafacanton rafacanton merged commit b55def1 into master Apr 8, 2024
37 checks passed
@rafacanton rafacanton deleted the rcanton/exception_empty_meshes branch April 8, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants