-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove numpy restriction to <2 #1864
Conversation
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1864 +/- ##
==========================================
- Coverage 88.10% 88.08% -0.03%
==========================================
Files 83 83
Lines 9951 9951
==========================================
- Hits 8767 8765 -2
- Misses 1184 1186 +2 |
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there any other modification to make anywhere else?
Only 4 files?
Apparently, yes, I guess this is because there are only very specific places where we return an |
Starting with
numpy==2
there is an explicit distinction betweennp.int32
andnp.int64
which results in a difference in string representations of certain numbers.Solves #1831