Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numpy restriction to <2 #1864

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Nov 5, 2024

Starting with numpy==2 there is an explicit distinction between np.int32 and np.int64 which results in a difference in string representations of certain numbers.
Solves #1831

Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi PProfizi added the dependencies Related to package requirements label Nov 5, 2024
@PProfizi PProfizi added this to the v0.13.2 milestone Nov 5, 2024
@PProfizi PProfizi self-assigned this Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (59eb1b2) to head (dec0c8e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1864      +/-   ##
==========================================
- Coverage   88.10%   88.08%   -0.03%     
==========================================
  Files          83       83              
  Lines        9951     9951              
==========================================
- Hits         8767     8765       -2     
- Misses       1184     1186       +2     

Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@BClappe BClappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there any other modification to make anywhere else?
Only 4 files?

@PProfizi
Copy link
Contributor Author

PProfizi commented Nov 7, 2024

Isn't there any other modification to make anywhere else? Only 4 files?

Apparently, yes, I guess this is because there are only very specific places where we return an np.int32 and test its string representation.

@PProfizi PProfizi merged commit 3849393 into master Nov 7, 2024
43 checks passed
@PProfizi PProfizi deleted the dependencies/remove_numpy_upper_limit branch November 7, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to package requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants