Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augment license check timeout in licensing example #1931

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

PProfizi
Copy link
Contributor

The timeout was set to 1.0s, which is sometimes too low on GitHub runners.

@PProfizi PProfizi added the CI/CD Related to CI/CD label Nov 25, 2024
@PProfizi PProfizi self-assigned this Nov 25, 2024
@PProfizi PProfizi requested a review from ansjhajjar November 25, 2024 15:36
@PProfizi PProfizi merged commit d778cdd into master Nov 25, 2024
34 checks passed
@PProfizi PProfizi deleted the ci/augment_license_check_timeout_in_example branch November 25, 2024 16:01
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (3d25208) to head (fa109e2).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1931      +/-   ##
==========================================
- Coverage   88.05%   88.03%   -0.03%     
==========================================
  Files          83       83              
  Lines        9973     9973              
==========================================
- Hits         8782     8780       -2     
- Misses       1191     1193       +2     
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant