-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example/asme 10 #265
Example/asme 10 #265
Conversation
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
=======================================
Coverage 85.89% 85.90%
=======================================
Files 52 52
Lines 5695 5697 +2
=======================================
+ Hits 4892 4894 +2
Misses 803 803 |
m2 = float(m2) | ||
|
||
############################################################################### | ||
# Streses & strains |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Streses & strains | |
# Stresses & strains |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
############################################################################### | ||
# Parameters input | ||
# ~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# ~~~~~~~~~~~~~ | |
# ~~~~~~~~~~~~~~~~ |
Title underline need to be at least as long as the title for sphinx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done for all lines
# values: alfasl = 2.2 & m2 = .288 | ||
# | ||
|
||
alfasl = input("Please introduce alfasl parameter from ASME\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examples if pyAnsys are used in the doc and to create Jupyter Notebook, they are not meant to be run as standalone python scripts. You can set a hardcoded value to your inputs but keep input("Please introduce alfasl parameter from ASME\n")
in a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
ansys/dpf/core/examples/examples.py
Outdated
@@ -19,3 +19,4 @@ | |||
msup_transient = os.path.join(_module_path, "msup_transient_plate1.rst") | |||
simple_cyclic = os.path.join(_module_path, "file_cyclic.rst") | |||
distributed_msup_folder = os.path.join(_module_path, 'msup_distributed') | |||
ASME_SecVIII_Div2 = os.path.join(_module_path, 'ASME_SecVIII_Div2.rst') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please keep the same naming standard as above for your file name (snake case)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
ansys/dpf/core/examples/examples.py
Outdated
@@ -19,3 +19,4 @@ | |||
msup_transient = os.path.join(_module_path, "msup_transient_plate1.rst") | |||
simple_cyclic = os.path.join(_module_path, "file_cyclic.rst") | |||
distributed_msup_folder = os.path.join(_module_path, 'msup_distributed') | |||
ASME_SecVIII_Div2 = os.path.join(_module_path, 'ASME_SecVIII_Div2.rst') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we try to not push result files in this repo to keep our package as light as possible. Could you please refer to this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed Ayush example
…xample/asme_10 # Conflicts: # ansys/dpf/core/examples/downloads.py
Hi @cbellot000 , |
* ASME example * Spaces removed * Modifications based on comments made on previous PR * test included in test_examples.py * unchanged files removed * unchanged files removed
Example 10 for documentation based on ASME Section VIII Division 2