Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example/asme 10 #265

Merged
merged 8 commits into from
Jun 20, 2022
Merged

Example/asme 10 #265

merged 8 commits into from
Jun 20, 2022

Conversation

jviqueg
Copy link
Contributor

@jviqueg jviqueg commented Jun 14, 2022

Example 10 for documentation based on ASME Section VIII Division 2

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #265 (0d94198) into master (27f1042) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   85.89%   85.90%           
=======================================
  Files          52       52           
  Lines        5695     5697    +2     
=======================================
+ Hits         4892     4894    +2     
  Misses        803      803           

m2 = float(m2)

###############################################################################
# Streses & strains
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Streses & strains
# Stresses & strains

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


###############################################################################
# Parameters input
# ~~~~~~~~~~~~~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# ~~~~~~~~~~~~~
# ~~~~~~~~~~~~~~~~

Title underline need to be at least as long as the title for sphinx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done for all lines

# values: alfasl = 2.2 & m2 = .288
#

alfasl = input("Please introduce alfasl parameter from ASME\n")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples if pyAnsys are used in the doc and to create Jupyter Notebook, they are not meant to be run as standalone python scripts. You can set a hardcoded value to your inputs but keep input("Please introduce alfasl parameter from ASME\n") in a comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -19,3 +19,4 @@
msup_transient = os.path.join(_module_path, "msup_transient_plate1.rst")
simple_cyclic = os.path.join(_module_path, "file_cyclic.rst")
distributed_msup_folder = os.path.join(_module_path, 'msup_distributed')
ASME_SecVIII_Div2 = os.path.join(_module_path, 'ASME_SecVIII_Div2.rst')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please keep the same naming standard as above for your file name (snake case)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -19,3 +19,4 @@
msup_transient = os.path.join(_module_path, "msup_transient_plate1.rst")
simple_cyclic = os.path.join(_module_path, "file_cyclic.rst")
distributed_msup_folder = os.path.join(_module_path, 'msup_distributed')
ASME_SecVIII_Div2 = os.path.join(_module_path, 'ASME_SecVIII_Div2.rst')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we try to not push result files in this repo to keep our package as light as possible. Could you please refer to this comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed Ayush example

@jviqueg jviqueg marked this pull request as ready for review June 16, 2022 05:52
…xample/asme_10

# Conflicts:
#	ansys/dpf/core/examples/downloads.py
@jviqueg
Copy link
Contributor Author

jviqueg commented Jun 16, 2022

Hi @cbellot000 ,
All required checks are successful, but there is a warning message about line 427 of downloads.py. I reviewed it and I don't see any issue. Should I merge the branch? Please let me know. Thanks!

@jviqueg jviqueg merged commit b087d1f into master Jun 20, 2022
@jviqueg jviqueg deleted the example/asme_10 branch June 20, 2022 15:03
cbellot000 pushed a commit that referenced this pull request Jul 8, 2022
* ASME example

* Spaces removed

* Modifications based on comments made on previous PR

* test included in test_examples.py

* unchanged files removed

* unchanged files removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants