Merge/retro/refactor actions grpc #339
Conversation
…into merge/retro/refactor_actions_grpc # Conflicts: # .github/workflows/ci.yml # .github/workflows/retro.yml # ansys/dpf/core/misc.py # tests/conftest.py
Codecov Report
@@ Coverage Diff @@
## merge/0.5.dev2 #339 +/- ##
=================================================
Coverage ? 80.36%
=================================================
Files ? 61
Lines ? 6615
Branches ? 0
=================================================
Hits ? 5316
Misses ? 1299
Partials ? 0 |
| - name: "Separate long Core tests" | ||
| shell: pwsh | ||
| run: | | ||
| New-Item -Path ".\" -Name "local_server_test" -ItemType "directory" |
There was a problem hiding this comment.
@PProfizi @cbellot000 just that you know, pytest as an --ignore flag that can be used as:
pytest ./tests --ignore tests\test_server.py --ignore tests\test_launcher.py
| @@ -122,8 +122,6 @@ def find_ansys(): | |||
| for version in sorted(versions, reverse=True): | |||
| if not version.isnumeric(): | |||
| continue | |||
| if version == __ansys_version__: | |||
There was a problem hiding this comment.
@cbellot000 that means that in ansys_version = 222 case, find_ansys() method won't be able to return an ansys_path based on AWP_ROOT222 ?
There was a problem hiding this comment.
@cbellot000 @anslpa yes the next elif might have been left by mistake. The get_ansys_path does try AWP_ROOT222 before calling find_ansys(), but you might want to still try to get it within find_ansys() for retro-compatibility.
No description provided.