Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Pipeline running examples with/without gatebin #342

Merged
merged 165 commits into from
Jul 27, 2022

Conversation

cbellot000
Copy link
Contributor

@cbellot000 cbellot000 commented Jul 26, 2022

Add new pipeline under GithubActions -> run examples without and without gatebon for the 3 different server types

elif DPF_SERVER_TYPE == "LEGACYGRPC":
core.SERVER_CONFIGURATION = core.AvailableServerConfigs.LegacyGrpcServer

list_tests = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anslpa, @PProfizi I chose these tests as "non-regression" test. Does that seem good to you?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbellot000 It looks good to me.

@cbellot000 cbellot000 marked this pull request as ready for review July 27, 2022 09:11
@anslpa
Copy link
Contributor

anslpa commented Jul 27, 2022

@cbellot000 Could you please point out what will need to be done to run the example "with gatebin" once this is available ? Just add a task that install gatebin into the .ci/yml file and then call the following steps with each server type :

      - name: "Check sanity with gatebin GRPC"
        shell: cmd
        run: |
          cd .ci
          python run_non_regression_examples.py
        env:
          DPF_SERVER_TYPE: GRPC

?

@cbellot000
Copy link
Contributor Author

ebin into the .ci/yml file and then call the following steps with each server typ

@anslpa I was sthinking that gatebin would be installed by default in our actions, and we will just uninstall it to test without

@cbellot000 cbellot000 changed the title Merge/retro/check no gatebin add Pipeline running examples with/without gatebin Jul 27, 2022
@cbellot000 cbellot000 merged commit 08c3b45 into master Jul 27, 2022
@cbellot000 cbellot000 deleted the merge/retro/check_no_gatebin branch July 27, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants