-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Pipeline running examples with/without gatebin #342
Conversation
…ge/retro/check_no_gatebin
…nsys/DPF-Core into merge/retro/check_no_gatebin
elif DPF_SERVER_TYPE == "LEGACYGRPC": | ||
core.SERVER_CONFIGURATION = core.AvailableServerConfigs.LegacyGrpcServer | ||
|
||
list_tests = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbellot000 It looks good to me.
…ge/retro/check_no_gatebin
@cbellot000 Could you please point out what will need to be done to run the example "with gatebin" once this is available ? Just add a task that install gatebin into the .ci/yml file and then call the following steps with each server type :
? |
@anslpa I was sthinking that gatebin would be installed by default in our actions, and we will just uninstall it to test without |
Add new pipeline under GithubActions -> run examples without and without gatebon for the 3 different server types