Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit testing of all supported Python versions #403

Merged
merged 23 commits into from
Aug 22, 2022

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Aug 12, 2022

Fixes support for vtk>=9.1.0.
Makes Python 3.10 available.
There is still a problem with Python 3.10 on Ubuntu-18.04, see #416.

@PProfizi PProfizi added the CI/CD Related to CI/CD label Aug 12, 2022
@PProfizi PProfizi self-assigned this Aug 12, 2022
@PProfizi PProfizi changed the title Ci/retro/add testing of all pythons Add explicit testing of all supported Python versions Aug 12, 2022
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #403 (97c8f16) into master (b6d1186) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   86.30%   86.57%   +0.27%     
==========================================
  Files          61       61              
  Lines        6701     6718      +17     
==========================================
+ Hits         5783     5816      +33     
+ Misses        918      902      -16     

@PProfizi
Copy link
Contributor Author

R222 Python3.7 Ubuntu-18.04:
test_python_plugins.py tests fail due to hashlib import, apparently because of it not finding openssl.
A problem with the provided python environment for test_python_plugins?

@cbellot000 Strangely this is a problem only for Python 3.7 on Ubuntu-18.04.

@PProfizi
Copy link
Contributor Author

PProfizi commented Aug 12, 2022

R222 & R221 Python3.10 Windows & Ubuntu-18.04:
A vtk==9.0.3 requirement is in requirements_test.txt but not in the setup.py. Will need to remove this. This might trigger issues discussed here: ansys/pydpf-post#132.

@PProfizi
Copy link
Contributor Author

Run_examples Python3.* Ubuntu-18.04:
The Install OpenGL step must be changed to the pyvista/setup-headless-display action to be compatible with Linux.

@@ -20,7 +20,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.8"]
python-version: ["3.7", "3.8", "3.9", "3.10"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PProfizi could you please either make a doc or setup a meeting (maybe with a slide on which pipelines are available) to decide when each pipeline is ran?

@PProfizi PProfizi mentioned this pull request Aug 16, 2022
@PProfizi PProfizi linked an issue Aug 16, 2022 that may be closed by this pull request
@PProfizi PProfizi merged commit cbce8f9 into master Aug 22, 2022
@PProfizi PProfizi deleted the ci/retro/add_testing_of_all_pythons branch August 22, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Python 3.10
3 participants