Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maint/get ansys version from pygate #420

Merged
merged 5 commits into from
Aug 23, 2022

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Aug 22, 2022

The ansys_version variable is now imported from the current install of ansys-dpf-gate package instead of being hard-coded in core. This variable is used to define the default ANSYS install version DPF will look for.

@PProfizi PProfizi added the maintenance Repository structure maintenance label Aug 22, 2022
@PProfizi PProfizi self-assigned this Aug 22, 2022
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #420 (8046b53) into master (91f6097) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
+ Coverage   86.36%   86.39%   +0.02%     
==========================================
  Files          61       61              
  Lines        6718     6717       -1     
==========================================
+ Hits         5802     5803       +1     
+ Misses        916      914       -2     

@PProfizi PProfizi merged commit d43f194 into master Aug 23, 2022
@PProfizi PProfizi deleted the maint/get_ansys_version_from_pygate branch August 23, 2022 09:42
PProfizi added a commit that referenced this pull request Aug 31, 2022
Maint/get ansys version from pygate (#420)

* Remove __ansys_version__ from setup.py

* Get __ansys_version__ from gate instead of core in core.misc

* Get __ansys_version__ from core.misc and not core._version

* Fix flake8 import error

(cherry picked from commit d43f194)

Related work items: #685003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Repository structure maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants