Overall edit of PyPDF-Core files. #452
Conversation
… to those necessary to address style issues discovered by Vale. All content will need to be reviwed again after completion of the PR. Note that some diagrams in examples were not being generated (locally at least), and lots of formatting changes are necessary to the examples.
…oc/edits_DPF_doc_round2
|
@PProfizi Lots of "Build and Test" checks failing. |
Hi @PipKat, yes this is normal, we are in the process of releasing PyPDPF-Core 0.6.0 due to a milestone, which means we had to release higher versions of its dependencies, potentially breaking the pipelines. The release should be done within two hours and everything should be working again. |
|
@RobPasMue I don't know how these example files got into this PR. I swear it wasn't like this on Friday. It was just failing Build and Test checks. |
|
Hi @PipKat from what I can see, the files where already there. And by updating the examples they got also updated... Probably @PProfizi can tell us a bit more. In any case, the examples files shouldn't be in the |
|
@PipKat @RobPasMue I am not sure when this got here, apparently there might be a commit missing somewhere where they were removed, but I've removed it and merged the current master. It should be ok now. |
…oc/edits_DPF_doc_round2
# Conflicts: # docs/source/getting_started/compatibility.rst # docs/source/getting_started/install.rst
…ts_DPF_doc_round2
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
==========================================
+ Coverage 86.08% 86.45% +0.37%
==========================================
Files 65 65
Lines 6963 6963
==========================================
+ Hits 5994 6020 +26
+ Misses 969 943 -26 |
|
@PProfizi @RobPasMue YES! All checks have passed. Now for a review? |
examples/07-python-operators/02-python_operators_with_dependencies.py
Outdated
Show resolved
Hide resolved
examples/07-python-operators/02-python_operators_with_dependencies.py
Outdated
Show resolved
Hide resolved
Apply changes from review comments Co-authored-by: PProfizi <100710998+PProfizi@users.noreply.github.com>
Co-authored-by: PProfizi <100710998+PProfizi@users.noreply.github.com>
|
@PProfizi Hi, Paul. I'm sure I introduced those problems somehow when I pulled in changes from the main branch. I ended up with conflicts in these files. I'm not sure what I did wrong since it seems so long ago that I took that action, but thanks for catching the issues. I've incorporated your feedback to date and hope that you can find time to finish your review and approve the PR. Thanks! |
|
@PProfizi The "Build and Test (3.10, ubuntu-latest" check has been running the entire day! |
Edits to example files were limited to those necessary to address style issues discovered by Vale. All content will need to be reviewed again after completion of the PR. Note that some diagrams in examples were not being generated (locally at least), and lots of formatting changes are necessary to the examples.