Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the documentation generation #479

Merged
merged 9 commits into from
Sep 13, 2022
Merged

Fix the documentation generation #479

merged 9 commits into from
Sep 13, 2022

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Sep 13, 2022

Solves #428

The Documentation check passes but the documentation artifact is actually empty (easily verified with its small size of 48 kB, should be more than 100MB).
The last known Documentation generation job to work was here on August 22.
Was rerun to check for unseen change in a dependency, it still passed.

Seems to have started with bump of Graphviz to 0.20.1 here. Cannot find an occurrence before that.

Two problems here:

the documentation check did not see something was wrong with the doc (artifact too small / step too short)
no error was raised although something went obviously wrong

EDIT: was due do the vtk known issue

@PProfizi PProfizi self-assigned this Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #479 (f682550) into master (912c121) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   86.52%   86.45%   -0.08%     
==========================================
  Files          65       65              
  Lines        6963     6963              
==========================================
- Hits         6025     6020       -5     
- Misses        938      943       +5     

@PProfizi PProfizi changed the title Ci/test doc Fix the documentation generation Sep 13, 2022
@PProfizi PProfizi merged commit fb35bac into master Sep 13, 2022
@PProfizi PProfizi deleted the ci/test_doc branch September 13, 2022 16:02
@PProfizi PProfizi added the CI/CD Related to CI/CD label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants