Fix deformation in fields container animate #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
==========================================
- Coverage 87.08% 87.06% -0.02%
==========================================
Files 68 68
Lines 7455 7453 -2
==========================================
- Hits 6492 6489 -3
- Misses 963 964 +1 |
PProfizi
changed the title
PProfizi
changed the title
anslpa
approved these changes
Oct 25, 2022
cbellot000
reviewed
Oct 26, 2022
| @@ -517,6 +517,11 @@ def animate(self, save_as=None, deform_by=None, scale_factor=1.0, **kwargs): | |||
| # Define the field extraction using the fields_container and indices | |||
| extract_field_op = dpf.core.operators.utility.extract_field(self) | |||
|
|
|||
| loop_over = self.get_time_scoping() | |||
| frequencies = self.time_freq_support.time_frequencies | |||
There was a problem hiding this comment.
@PProfizi I don't understand this changes, it means that we can't animate if we don't have a time freq support?
There was a problem hiding this comment.
@cbellot000 That was already the case, I just moved this up. Right now the animation is based on the TimeFreqSupport, yes.
There was a problem hiding this comment.
to add in the US to handle having no time freq support and to be able to create an animator with a mesh + a fields container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error has been found in the computation of the deformation field.