Fix server version parsing to correctly treat ansys_dpf_server #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #673 +/- ##
==========================================
+ Coverage 88.16% 88.23% +0.06%
==========================================
Files 69 69
Lines 7757 7760 +3
==========================================
+ Hits 6839 6847 +8
+ Misses 918 913 -5 |
cbellot000
approved these changes
Dec 6, 2022
PProfizi
approved these changes
Dec 7, 2022
|
It was needed to add check to ensure ansys_path was not None, because None type is not iterable and that's what is gotten for run on Docker (CI/CD build issue). |
PProfizi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ansys_dpf_server_win_v2023.2.pre0 is used and this is contained in the server folder name, v202 is parsed as Ansys version and GrpcLegacyServer is the default. This prevents this behavior to have InProcessServer instead.