-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable automatic update of operators #699
Conversation
This reverts commit 9bfb806.
Co-authored-by: PProfizi <PProfizi@users.noreply.github.com>
…nto maint/fix_src_code_generation
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
==========================================
- Coverage 88.60% 88.44% -0.16%
==========================================
Files 71 71
Lines 8081 8091 +10
==========================================
- Hits 7160 7156 -4
- Misses 921 935 +14 |
…e fixed." This reverts commit b536315.
…erator is capitalized server-side. However, the doc generation operator seems to use tje scripting name, which is not. These will need to be made coherent.
…ssure operator is capitalized server-side. However, the doc generation operator seems to use tje scripting name, which is not. These will need to be made coherent." This reverts commit f57df63.
…context public method.
Co-authored-by: PProfizi <PProfizi@users.noreply.github.com>
@cbellot000 this PR is ready for merging, it contains:
The next step is to call this workflow when the server is updated, so that updating the server automatically proposes the corresponding update of the python code for the operators. The code quality is screaming due to the operators and the code_generation.py script but is not a problem. |
This PR adds a workflow to be triggered manually or by the dpf-standalone repository, which automatically regenerates the operators' Python code using the DPF Server in question, and creates a PR on pydpf-core with the new operators.
This goes one step towards having an automatic update of operators on update of the development server.
Further required steps:
docs/source/_static/dpf_entry.html
anddocs/source/_static/dpf_premium.html
) and commit that to the same PR as the operators (see.ci/operator_doc_per_context.py
)/!\ The internal name for the pressure operator, used during operator generation, is capitalized server-side. However, the doc generation operator seems to use the scripting name, which is lower-case. These will need to be made coherent. Until this is solved, one of these steps will always fail.
Python classes generated for operators should be named after the scripting name (here
pressure
) which is the case in master. The init should then importpressure
, and the operator code generation process is wrong if it generates aPressure
operator.-> the operator cgns::cgns::Pressure is ignored during operators build, a bug has been raised server-side.
Once merged: trigger the update_operators workflow from the server's pipelines
This PR will fix #720.