-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to pyproject.toml files #707
Conversation
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
==========================================
- Coverage 88.49% 88.44% -0.05%
==========================================
Files 71 71
Lines 8091 8091
==========================================
- Hits 7160 7156 -4
- Misses 931 935 +4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes. LGTM! Let's wait for @PProfizi review as well.
pyproject.toml
Outdated
[project] | ||
# Check https://flit.readthedocs.io/en/latest/pyproject_toml.html for all available sections | ||
name = "ansys-dpf-core" | ||
version = "0.7.dev0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PProfizi, how should we define version
here? This is following other pyansys repos convention, but I remember we talked about PyDPF-Core using 0.7.Z.dev0, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GuillemBarroso @Revathyvenugopal162 Indeed, the version should be 0.7.3.dev0 (we are releasing 0.7.2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok i got your point. but usually we will not keep track of the patch releases, 0.7.dev0 or if we have already 0.7 release, then 0.8.dev0 is the usual way of keeping track, so that the patch release is not going to affect the dev version. https://peps.python.org/pep-0440/#developmental-releases. but no offence. ultimately the developers can decide .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with either. I think it would be nice to be consistent with other repos and use 0.8.dev0, but I am not fully aware of the implications of changing this. @PProfizi, your call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GuillemBarroso @Revathyvenugopal162 , this needs to be 0.7.3.dev0, which was for example set in #709
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am alright with what I saw in the pyproject.toml
Do you know why black went and edited all files again? A change with the new version?
Also we might want to publish on testPyPI to make sure the metadata is alright.
Co-authored-by: Guillem Barroso <53979143+GuillemBarroso@users.noreply.github.com>
Co-authored-by: PProfizi <100710998+PProfizi@users.noreply.github.com>
Co-authored-by: Guillem Barroso <53979143+GuillemBarroso@users.noreply.github.com>
The default line length formatting for black is 80. but in flake 8 we specified to 100, so i changed to 100. And i think it is a good number. |
Co-authored-by: PProfizi <100710998+PProfizi@users.noreply.github.com>
Yep. I like 100. |
No description provided.