Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to DPF-Core RST and TXT files #729

Merged
merged 3 commits into from
Jan 10, 2023
Merged

Edits to DPF-Core RST and TXT files #729

merged 3 commits into from
Jan 10, 2023

Conversation

PipKat
Copy link
Member

@PipKat PipKat commented Dec 29, 2022

@PProfizi I've done a quick edit to the RST and TEXT files. Initially, one asterisk was used to tag terms in italic and two asterisks were used to tag UI elements in bold. Given that so many tags for terms were in bold, I changed all tags to bold. I will consult later with the PyAnsys team to evaluate this approach. If there is time before the release, I can go through the PY files for the API reference and the examples, but I am not sure that there is enough time to do this. (I believe that you told me that any edits had to be in by the end of the year.) One PyAnsys team has replacing "optional" in the parameter description with "default: x" where x is the default value. This makes the default more visible and eliminates words in the subsequent description. We could perhaps do this in your library documentation the next time the PY files for the API reference section are edited.

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #729 (c1ef1b0) into master (d503907) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
+ Coverage   88.64%   88.70%   +0.05%     
==========================================
  Files          71       71              
  Lines        8088     8091       +3     
==========================================
+ Hits         7170     7177       +7     
+ Misses        918      914       -4     

@PipKat PipKat requested a review from PProfizi December 29, 2022 21:22
@PipKat PipKat added the documentation Improvements or additions to documentation label Dec 29, 2022
@PProfizi
Copy link
Contributor

PProfizi commented Jan 2, 2023

Hi @PipKat, thank you for this! I agree that making this more coherent is good.
As for the release deadlines, I do not think we now have specific ones. PyDPF-Core will be released whenever necessary, and now that DPF Server is released every 4-6 weeks, this means we will continue with a release frequency of around one per month.
This means you can work on this whenever you have time, and it will be deployed live within a month.

Concerning the "default" for other pyansys libraries, I think this comes from their use of sphinx-autodoc-typehints, which automatically builds the type definitions in docstrings based on the type hinting done in the code. This is integrated in PyDPF-Post but apparently not yet in PyDPF-Core. Once this is integrated, the docstring for an optional argument with a default value will by default look like what you described without the need to write it explicitely. You can find the related discussion here

docs/source/index.rst Outdated Show resolved Hide resolved
docs/source/index.rst Outdated Show resolved Hide resolved
Incorporate Paul's comments

Co-authored-by: PProfizi <100710998+PProfizi@users.noreply.github.com>
@PipKat
Copy link
Member Author

PipKat commented Jan 3, 2023

@PProfizi Thanks for catching so many small errors! I appreciate your careful review and have incorporated all of your proposed changes. Please review/accept and merge if you are OK with doing so!

@PProfizi
Copy link
Contributor

PProfizi commented Jan 4, 2023

Hey @cbellot000 @anslpa, could you please take a look at the proposed changes for user_guide/server_types.rst?
I am not so sure the new wording fits conveniently with what we meant initially.

@PProfizi PProfizi requested a review from anslpa January 6, 2023 10:21
@PipKat
Copy link
Member Author

PipKat commented Jan 10, 2023

@cbellot000 Hi, there! Any chance that you can review user_guide/server_types.rst per Paul's request soon so that I can get this PR closed and merged?

@PProfizi
Copy link
Contributor

@cbellot000 Hi, there! Any chance that you can review user_guide/server_types.rst per Paul's request soon so that I can get this PR closed and merged?

Hi @PipKat, I think she was okay with it, so I'll approve myself and you can merge.

@PProfizi PProfizi self-requested a review January 10, 2023 16:18
@PipKat
Copy link
Member Author

PipKat commented Jan 10, 2023

@PProfizi Thanks for the update!

@PipKat PipKat merged commit d92e766 into master Jan 10, 2023
@PipKat PipKat deleted the docs/minor_edits branch January 10, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants