-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edits to DPF-Core RST and TXT files #729
Conversation
Codecov Report
@@ Coverage Diff @@
## master #729 +/- ##
==========================================
+ Coverage 88.64% 88.70% +0.05%
==========================================
Files 71 71
Lines 8088 8091 +3
==========================================
+ Hits 7170 7177 +7
+ Misses 918 914 -4 |
Hi @PipKat, thank you for this! I agree that making this more coherent is good. Concerning the "default" for other pyansys libraries, I think this comes from their use of |
Incorporate Paul's comments Co-authored-by: PProfizi <100710998+PProfizi@users.noreply.github.com>
@PProfizi Thanks for catching so many small errors! I appreciate your careful review and have incorporated all of your proposed changes. Please review/accept and merge if you are OK with doing so! |
Hey @cbellot000 @anslpa, could you please take a look at the proposed changes for user_guide/server_types.rst? |
@cbellot000 Hi, there! Any chance that you can review user_guide/server_types.rst per Paul's request soon so that I can get this PR closed and merged? |
Hi @PipKat, I think she was okay with it, so I'll approve myself and you can merge. |
@PProfizi Thanks for the update! |
@PProfizi I've done a quick edit to the RST and TEXT files. Initially, one asterisk was used to tag terms in italic and two asterisks were used to tag UI elements in bold. Given that so many tags for terms were in bold, I changed all tags to bold. I will consult later with the PyAnsys team to evaluate this approach. If there is time before the release, I can go through the PY files for the API reference and the examples, but I am not sure that there is enough time to do this. (I believe that you told me that any edits had to be in by the end of the year.) One PyAnsys team has replacing "optional" in the parameter description with "default: x" where x is the default value. This makes the default more visible and eliminates words in the subsequent description. We could perhaps do this in your library documentation the next time the PY files for the API reference section are edited.