Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Python <4 versions #773

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Allow for Python <4 versions #773

merged 1 commit into from
Jan 30, 2023

Conversation

RobPasMue
Copy link
Member

When moving from pyproject.toml to setup.py, PyDPF-Core stopped supporting Python 3.11+ versions. In your previous setup.py file, your Python limitations were >=3.7, <4 and now they are >=3.7, <3.11. This will cause a conflict with the PyAnsys metapackage as we can tell from: https://github.com/pyansys/pyansys-dev/issues/4

I submit this PR to replicate the previous behavior you had. I understand that this change was unintended. Consider adding a Python 3.11 smoke test in your workflow as well =)

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #773 (29e3ea5) into master (2fbf15c) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
- Coverage   88.67%   88.59%   -0.09%     
==========================================
  Files          71       71              
  Lines        8114     8107       -7     
==========================================
- Hits         7195     7182      -13     
- Misses        919      925       +6     

Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for solving this @RobPasMue .

@PProfizi
Copy link
Contributor

Hey @RobPasMue, thanks for this change, although I do not think it was a mistake. We initially did not support 3.11 explicitly, hence the lack of testing. What I understand though is that pyansys packages should explicitly support 3.11 or at the very least allow it.
What I will do is merge this PR so we do not prevent the pyansys metapackage CI from passing, yet I will also create an issue here to add explicit testing of 3.11. I am not fond of just doing smoke tests, so we usually test all Python versions we are supposed to support. We should most likely move to running only examples though.

@PProfizi PProfizi changed the title Supporting Python <4 versions Allow for Python <4 versions Jan 30, 2023
@PProfizi PProfizi merged commit 73eb599 into master Jan 30, 2023
@PProfizi PProfizi deleted the maint/py311-support branch January 30, 2023 08:40
@PProfizi PProfizi added the dependencies Related to package requirements label Jan 30, 2023
@RobPasMue
Copy link
Member Author

Hey @RobPasMue, thanks for this change, although I do not think it was a mistake. We initially did not support 3.11 explicitly, hence the lack of testing. What I understand though is that pyansys packages should explicitly support 3.11 or at the very least allow it. What I will do is merge this PR so we do not prevent the pyansys metapackage CI from passing, yet I will also create an issue here to add explicit testing of 3.11. I am not fond of just doing smoke tests, so we usually test all Python versions we are supposed to support. We should most likely move to running only examples though.

Oh great then. Yeah, we are avoiding explicit disregard of Python 3.11 - at least allow it even if you are not sure if it works perfectly fine or not. If you intend on testing all the Python versions you support that's even better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to package requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants