Fix and improve install section #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PProfizi
requested review from
rlagha,
anslpa,
cbellot000,
rafacanton and
JennaPaikowsky
PProfizi
commented
Feb 9, 2023
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
==========================================
+ Coverage 88.61% 88.72% +0.11%
==========================================
Files 72 72
Lines 8180 8180
==========================================
+ Hits 7249 7258 +9
+ Misses 931 922 -9 |
rafacanton
reviewed
Feb 10, 2023
|
|
||
| Beware that PyDPF-Core wheelhouses do not include the optional plotting dependencies. | ||
| To allow for plotting capabilities, also download the wheels corresponding to your platform and Python interpreter version | ||
| for `PyVista <https://pypi.org/project/pyvista/#files>`_ and |
There was a problem hiding this comment.
Maybe we could mention the versions for PyVista and Matplotlib (the url points to the latest)
There was a problem hiding this comment.
@rafacanton the thing is these are going to change all the time. We are supposed to support the latest versions of each.
The current limitation on PyVista is actually only for the documentation generation pipeline on GitHub since there is an issue I have not been able to reproduce locally.
There was a problem hiding this comment.
@PProfizi OK, if we are always going to support the last one, then it LGTM!
PProfizi
commented
Feb 10, 2023
rafacanton
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and improve the section concerning installation without an internet connection.
Also improve the regular install section by mentioning the
[plotting]option.