Add FluidSimulation.zone_mesh() to get the mesh of a single zone #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbellot000
reviewed
Apr 3, 2024
cbellot000
reviewed
May 3, 2024
| @@ -177,6 +178,28 @@ def mesh_info(self) -> FluidMeshInfo: | |||
| self._mesh_info = FluidMeshInfo(self._model.metadata.mesh_info) | |||
| return self._mesh_info | |||
|
|
|||
| def zone_mesh(self, zone: Union[int, str]) -> Mesh: | |||
There was a problem hiding this comment.
@PProfizi don't you think we should create a mesh api container here ? for extensibility of our APIs I think it can be useful. We could need to add other APIs like: zone_meshes(zones), merged_mesh_for_zones()...
There was a problem hiding this comment.
I've marked this as a global feature request for mesh manipulation in PyDPF-Post.
This one though was a specific request so I'll merge it on its own for now.
To me this method will still be there, just improved (for example allow to select several zones at once and get a single Mesh.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
==========================================
+ Coverage 85.11% 85.17% +0.06%
==========================================
Files 52 52
Lines 5173 5194 +21
==========================================
+ Hits 4403 4424 +21
Misses 770 770
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.