Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Polygon based padstack definition creation #559

Merged
merged 9 commits into from
Jun 10, 2024

Conversation

svandenb-dev
Copy link
Collaborator

No description provided.

@svandenb-dev svandenb-dev linked an issue Jun 10, 2024 that may be closed by this pull request
SMoraisAnsys
SMoraisAnsys previously approved these changes Jun 10, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left some minor comments.

src/pyedb/dotnet/edb_core/padstack.py Outdated Show resolved Hide resolved
src/pyedb/dotnet/edb_core/padstack.py Outdated Show resolved Hide resolved
svandenb-dev and others added 3 commits June 10, 2024 13:40
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
SMoraisAnsys
SMoraisAnsys previously approved these changes Jun 10, 2024
Copy link
Collaborator

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 703c5c3 into main Jun 10, 2024
25 checks passed
@svandenb-dev svandenb-dev deleted the create-polygon-padstack-definition branch June 10, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEAT: Support Polygon based padstack creation
3 participants