Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Create port on pin bug fix #732

Merged
merged 22 commits into from
Aug 21, 2024
Merged

Conversation

svandenb-dev
Copy link
Collaborator

closing #731

SMoraisAnsys
SMoraisAnsys previously approved these changes Aug 20, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a minor comment.

src/pyedb/dotnet/edb_core/components.py Outdated Show resolved Hide resolved
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@svandenb-dev svandenb-dev merged commit fbc7a13 into main Aug 21, 2024
25 checks passed
@svandenb-dev svandenb-dev deleted the create-port-on-pin-bug-fix branch August 21, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants