FIX: Set solder ball fix with negative diameter #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/pyedb/dotnet/edb_core/edb_data/hfss_pi_simulation_setup_data.py # src/pyedb/dotnet/edb_core/utilities/simulation_setup.py
# Conflicts: # src/pyedb/dotnet/edb_core/components.py
hui-zhou-a
approved these changes
Aug 22, 2024
| @@ -871,7 +871,6 @@ def create_port_on_pins(self, refdes, pins, reference_pins, impedance=50.0, port | |||
| elif "-" in ref_pin_name and ref_pin_name.split("-")[1] in refdes_pins: | |||
| ref_cmp_pins.append(refdes_pins[ref_pin_name.split("-")[1]]) | |||
| if not ref_cmp_pins: | |||
| self._logger.warning("No reference pins found during port creation. Port is not defined.") | |||
There was a problem hiding this comment.
Why do you remove this warning ? Can you make it a debug warning if you don't want people to see it ?
| _sb_diam = min([self._get_edb_value(val).ToDouble() for val in pad_params[1]]) | ||
| sball_diam = _sb_diam | ||
| _sb_diam = abs(min([self._get_edb_value(val).ToDouble() for val in pad_params[1]])) | ||
| sball_diam = 0.8 * _sb_diam |
There was a problem hiding this comment.
Why do you multiply by 0.8 ?
There was a problem hiding this comment.
this is an arbitrary value based on experiment. When users export to 3D modeler having the same value cause trouble with meshing. Using a smaller value prevent this issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some cases EDB api is returning negative pad dimension causing solder balls settings failure.
closing #736