Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: import_gds_file #826

Merged
merged 18 commits into from
Oct 1, 2024
Merged

FIX: import_gds_file #826

merged 18 commits into from
Oct 1, 2024

Conversation

gfetsis
Copy link
Collaborator

@gfetsis gfetsis commented Sep 27, 2024

No description provided.

@gfetsis gfetsis linked an issue Sep 27, 2024 that may be closed by this pull request
2 tasks
@gfetsis gfetsis changed the title Gds FIX FIX: import_gds_file Sep 27, 2024
svandenb-dev
svandenb-dev previously approved these changes Sep 27, 2024
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to log instead of printing.
Also, if it doesn't make sense to run the command later on, I'd raise an exception RuntimeError.

src/pyedb/dotnet/edb.py Outdated Show resolved Hide resolved
src/pyedb/dotnet/edb.py Outdated Show resolved Hide resolved
gfetsis and others added 2 commits September 30, 2024 12:32
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@gfetsis
Copy link
Collaborator Author

gfetsis commented Sep 30, 2024

@SMoraisAnsys I committed the proposed changes. As long as there is an input GDS (even without map or tech file), the translator should be ran so I didn't add the exception RuntimeError. Let me know if that makes sense.

Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great job

@svandenb-dev svandenb-dev merged commit afdf399 into main Oct 1, 2024
29 checks passed
@svandenb-dev svandenb-dev deleted the GDS_Fix_new branch October 1, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located in function import_gds_file()
4 participants