Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: setup types #854

Merged
merged 5 commits into from
Oct 18, 2024
Merged

FIX: setup types #854

merged 5 commits into from
Oct 18, 2024

Conversation

hui-zhou-a
Copy link
Collaborator

@hui-zhou-a hui-zhou-a commented Oct 16, 2024 •
edited
Loading

PyEDB is failing on 24R1

@hui-zhou-a hui-zhou-a changed the title Fix setup types FIX: setup types Oct 16, 2024
SMoraisAnsys
SMoraisAnsys reviewed Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure to understand what was failing in 2024.1.
Is it because some SimulationSetupType.whateverthename do not exist in that version ?
I left a minor comment due to an unused variable.

src/pyedb/dotnet/edb.py Outdated Show resolved Hide resolved
@hui-zhou-a @SMoraisAnsys
Update src/pyedb/dotnet/edb.py
2f62e9c 
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@hui-zhou-a
Copy link
Collaborator Author

I'm not sure to understand what was failing in 2024.1. Is it because some SimulationSetupType.whateverthename do not exist in that version ? I left a minor comment due to an unused variable.

That's right. below property doesn't exist in 2024.1.

self.edb_api.utility.utility.SimulationSetupType.kRaptorX

@SMoraisAnsys
Copy link
Collaborator

I'm not sure to understand what was failing in 2024.1. Is it because some SimulationSetupType.whateverthename do not exist in that version ? I left a minor comment due to an unused variable.

That's right. below property doesn't exist in 2024.1.

self.edb_api.utility.utility.SimulationSetupType.kRaptorX

If there is no changes associated to the "name" of the SimulationSetupType in coming AEDT releases then this changes will be great. Otherwise, we might want to keep the previous approach and add extra if condition based on AEDT versions. For example, we could have an if statement like <=2024.1 before the test on kRaptorX.

@svandenb-dev svandenb-dev merged commit 9501694 into main Oct 18, 2024
29 checks passed
@svandenb-dev svandenb-dev deleted the fix-setup-types branch October 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hui-zhou-a @SMoraisAnsys @svandenb-dev