Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: variable description #896

Merged
merged 5 commits into from
Nov 20, 2024
Merged

FEAT: variable description #896

merged 5 commits into from
Nov 20, 2024

Conversation

hui-zhou-a
Copy link
Collaborator

No description provided.

@hui-zhou-a hui-zhou-a added the grpc-transition Changes that need to be included in gRPC transition label Nov 14, 2024
@github-actions github-actions bot added the testing Anything related to testing label Nov 14, 2024
@hui-zhou-a hui-zhou-a changed the title FEATURE: variable description FEAT: variable description Nov 15, 2024
SMoraisAnsys
SMoraisAnsys previously approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I proposed a minor change to ensure that not providing a description behaves as expected. This is required since var_server[1].SetVariableDescription(variable_name, description) is triggered even if no description is provided.

tests/legacy/system/test_edb.py Show resolved Hide resolved
@hui-zhou-a @SMoraisAnsys
Update tests/legacy/system/test_edb.py
cd5d8b8 
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.36%. Comparing base (500756e) to head (7ded75b).
Report is 301 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   84.16%   82.36%   -1.80%     
==========================================
  Files         105      159      +54     
  Lines       17938    20878    +2940     
==========================================
+ Hits        15097    17197    +2100     
- Misses       2841     3681     +840
---- 🚨 Try these New Features:

SMoraisAnsys
SMoraisAnsys approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hui-zhou-a hui-zhou-a merged commit 056fb81 into main Nov 20, 2024
29 checks passed
@hui-zhou-a hui-zhou-a deleted the variable-description branch November 20, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

@svandenb-dev svandenb-dev Awaiting requested review from svandenb-dev

Assignees
No one assigned
Labels
grpc-transition Changes that need to be included in gRPC transition testing Anything related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hui-zhou-a @codecov-commenter @SMoraisAnsys