Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Material to match gRPC implementation #901

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

Following a discussion on how gRPC's Material is currently implemented.

Note: prior to this changes, the implementation was leveraging a __property attribute which was updated every time a property, like conductivity, was accessed. However, the gRPC doesn't have such attribute so it does not make sense to keep it in dotnet.

@github-actions github-actions bot added documentation Improvements or additions to documentation grpc-transition Changes that need to be included in gRPC transition labels Nov 19, 2024
svandenb-dev
svandenb-dev previously approved these changes Nov 19, 2024
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.36%. Comparing base (500756e) to head (6ab05b7).
Report is 301 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #901      +/-   ##
==========================================
- Coverage   84.16%   82.36%   -1.80%     
==========================================
  Files         105      159      +54     
  Lines       17938    20872    +2934     
==========================================
+ Hits        15097    17191    +2094     
- Misses       2841     3681     +840     
---- 🚨 Try these New Features:

Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 719ef9f into main Nov 20, 2024
29 checks passed
@svandenb-dev svandenb-dev deleted the refactor/material-to-match-grpc-implementation branch November 20, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation grpc-transition Changes that need to be included in gRPC transition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants