-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR: Material to match gRPC implementation #901
REFACTOR: Material to match gRPC implementation #901
Conversation
This reverts commit e109b5e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit 268948e.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #901 +/- ##
==========================================
- Coverage 84.16% 82.36% -1.80%
==========================================
Files 105 159 +54
Lines 17938 20872 +2934
==========================================
+ Hits 15097 17191 +2094
- Misses 2841 3681 +840
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Following a discussion on how gRPC's
Material
is currently implemented.