FIX: Property is_enabled was defined several times in the same class. #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxJPRey
commented
Dec 26, 2024
Comment on lines
-349
to
-370
| @property | ||
| def is_enabled(self): | ||
| """Flag indicating if the current object is enabled. | ||
|
|
||
| Returns | ||
| ------- | ||
| bool | ||
| ``True`` if current object is enabled, ``False`` otherwise. | ||
| """ | ||
| if self.type in ["Resistor", "Capacitor", "Inductor"]: | ||
| return self.component_property.IsEnabled() | ||
| else: # pragma: no cover | ||
| return True | ||
|
|
||
| @is_enabled.setter | ||
| def is_enabled(self, enabled): | ||
| """Enables the current object.""" | ||
| if self.type in ["Resistor", "Capacitor", "Inductor"]: | ||
| component_property = self.component_property | ||
| component_property.SetEnabled(enabled) | ||
| self.edbcomponent.SetComponentProperty(component_property) | ||
|
|
There was a problem hiding this comment.
@hui-zhou-a @svandenb-dev . I think we can delete those lines as is_enabled is deprecated in favor of enabled based on this comment:
pyedb/src/pyedb/dotnet/edb_core/cell/hierarchy/component.py
Lines 183 to 197 in 3172b5b
Your expertise will decide if we keep it or not 😃 .
MaxJPRey
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #959 +/- ##
==========================================
+ Coverage 82.69% 82.72% +0.03%
==========================================
Files 160 160
Lines 21117 21108 -9
==========================================
- Hits 17462 17461 -1
+ Misses 3655 3647 -8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.