Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python support 3.12 and remove pyansys-docker fork requirement #323

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

mariostieriansys
Copy link
Collaborator

@mariostieriansys mariostieriansys commented Oct 6, 2023

The PR does three things:

  1. Remove support to 3.8 and add support to 3.12
  2. Remove the need for the pyansys-docker fork, now the docker module works (tests are passing!). The fork was having issues since the code contains calls to distutils, removed from 3.12
  3. I started seeing vale errors against string like ":func:`attrinfo<ansys.api.pyensight.ens_annot.ENS_ANNOT.attrinfo>", where the code style check was complaining that after "E" a space was required. This is of course not an issue being this a reference to an area of our docs; so I modifed the .vale.ini configuration file to ignore :func: and :samp: blocks

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

Merging #323 (5d3432b) into main (90d0626) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #323   +/-   ##
=======================================
  Coverage   81.08%   81.08%           
=======================================
  Files          18       18           
  Lines        2500     2500           
  Branches      437      437           
=======================================
  Hits         2027     2027           
  Misses        319      319           
  Partials      154      154           
Files Coverage Δ
src/ansys/pyensight/core/dockerlauncher.py 81.04% <100.00%> (ø)

@mariostieriansys
Copy link
Collaborator Author

@margalva I was getting issues on using our docker module fork against Python 3.12, since it uses distutils which has been removed from 3.12

I have found that the standard docker module is now working correctly for us, and so in this PR I have removed the dependency on the fork. You may be interested in checking and doing the same

@mariostieriansys mariostieriansys merged commit 2d988e6 into main Oct 6, 2023
21 checks passed
@mariostieriansys mariostieriansys deleted the mostieri/python312_support branch October 6, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants