Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/obj performance #340

Merged
merged 10 commits into from
Dec 7, 2023
Merged

Fix/obj performance #340

merged 10 commits into from
Dec 7, 2023

Conversation

randallfrank
Copy link
Collaborator

No description provided.

randallfrank and others added 5 commits November 9, 2023 17:27
In 2024 R2 there is an extended __repr__ for performance.
Make it possible to use remotely cached, owned objects.
Speed up object transmission.
Support remote object references.
Clean up docs.
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (fbae34b) 74.79% compared to head (5193b62) 74.36%.

Files Patch % Lines
src/ansys/pyensight/core/ensobj.py 46.15% 9 Missing and 5 partials ⚠️
src/ansys/pyensight/core/session.py 87.05% 8 Missing and 3 partials ⚠️
src/ansys/pyensight/core/listobj.py 40.00% 5 Missing and 1 partial ⚠️
src/ansys/pyensight/core/ensight_grpc.py 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
- Coverage   74.79%   74.36%   -0.43%     
==========================================
  Files          18       18              
  Lines        2793     2852      +59     
  Branches      501      514      +13     
==========================================
+ Hits         2089     2121      +32     
- Misses        545      564      +19     
- Partials      159      167       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Include a test for the ENS_GROUP remote object.
Re-organize the code a bit to improve coverage.
Apply formatting rules.
Additional "catchall" exceptions that should never be reached marked as not part of the coverage test.
@randallfrank randallfrank merged commit 045557b into main Dec 7, 2023
21 checks passed
@randallfrank randallfrank deleted the fix/obj_performance branch December 7, 2023 15:05
mariostieriansys added a commit that referenced this pull request Jan 16, 2024
Co-authored-by: Mario Ostieri <mario.ostieri@ansys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants